Move /connect/analytics to app router #4893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4893 +/- ##
=======================================
Coverage 47.61% 47.61%
=======================================
Files 1057 1057
Lines 57221 57221
Branches 3924 3924
=======================================
Hits 27246 27246
Misses 29286 29286
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
jnsdls
force-pushed
the
10-03-add_billing_alerts_on__connect_layout_in_app_router
branch
from
0c31e82 to
e712138
Compare
jnsdls
force-pushed
the
10-03-move__connect_analytics_to_app_router
branch
from
c119272 to
4aeeb94
Compare
Contributor
size-limit report 📦
|
MananTank
force-pushed
the
10-03-move__connect_analytics_to_app_router
branch
from
4aeeb94 to
f95fa52
Compare
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
MananTank
force-pushed
the
10-03-move__connect_analytics_to_app_router
branch
from
f95fa52 to
f20b046
Compare
MananTank
force-pushed
the
10-03-move__connect_analytics_to_app_router
branch
from
e34b9f4 to
82ed00b
Compare
MananTank
force-pushed
the
10-03-move__connect_analytics_to_app_router
branch
from
82ed00b to
2470eac
Compare
jnsdls
approved these changes
Oct 3, 2024
apps/dashboard/src/app/(dashboard)/dashboard/connect/analytics/[clientId]/page.tsx
Outdated
Show resolved
Hide resolved
MananTank
force-pushed
the
10-03-move__connect_analytics_to_app_router
branch
from
2470eac to
b70a030
Compare
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `Analytics` section of the dashboard by introducing a new `AnalyticsPageAPIKeysMenu`, updating the `ApiKeysMenu` component to use a more generic type, and improving the handling of API keys for better user experience.
### Detailed summary
- Removed `DashboardConnectAnalytics` from constants.
- Added `AnalyticsPageAPIKeysMenu` to manage API keys.
- Updated `ApiKeysMenu` to use a generic type for `apiKeys`.
- Modified selection logic in `ApiKeysMenu` to use `key` instead of `id`.
- Enhanced page redirection logic based on API keys availability.
> The following files were skipped due to too many changes: `apps/dashboard/tsconfig.tsbuildinfo`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
MananTank
force-pushed
the
10-03-move__connect_analytics_to_app_router
branch
from
b70a030 to
615dd1e
Compare
graphite-app
bot
deleted the
10-03-move__connect_analytics_to_app_router
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the
Analyticsfunctionality in the dashboard by updating the API key management and connecting analytics components. It introduces new components and refactors existing ones for better type safety and user experience.Detailed summary
DashboardConnectAnalyticsconstant.AnalyticsPageAPIKeysMenucomponent for selecting API keys.ApiKeysMenuto use a generic type for better flexibility.Pagecomponent for handling authentication and API key redirection.NoKeysCreatedPageto inform users when no API keys are available.